Carousel bugs

[justinlau12]

Describe the bug

2 bugs with sl-carousel currently:
1. For different value slides per page and move, for even number screenshots it doesn't go to the last screenshot. Ever. But for an odd number of screenshots it goes to the last screenshot just fine.
2. Loop = true has a bug: after loading carousel for first time on page, then clicking somewhere else and going back to the same page w carousel, the screenshot starting index is all messed up.

To Reproduce

Steps to reproduce the behavior:
I really only care about the 1st bug atm, because loop was a workaround for the 1st bug but even loop has bugs.

1. Set slides per page to 2, slides per move to 1 in the component attributes.
2. Set an even number of slides in the component
3. Scroll using the arrow buttons, doesn't navigate to last screenshot (next button disables)

Browser / OS

• OS: Windows
• Browser: all

[esharri2]

Reproduction of issue (first one): https://codepen.io/esharri2/pen/yLGOgXv

[KonnorRogers]

@esharri2 thanks for the reproduction, I can see the issue with the slides-per-move to slides-per-page being different creates weird UX.

[alenaksu]

@KonnorRogers Happy to help if no one else is working on this already

[claviska]

@alenaksu have at it! Thank you