Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't swipe to change slide on Android Firefox sl-carousel #1757

Closed
acoreyj opened this issue Dec 3, 2023 · 2 comments · Fixed by #1748
Closed

can't swipe to change slide on Android Firefox sl-carousel #1757

acoreyj opened this issue Dec 3, 2023 · 2 comments · Fixed by #1748
Labels
bug Things that aren't working right in the library.

Comments

@acoreyj
Copy link

acoreyj commented Dec 3, 2023

Describe the bug

Swiping a slide looks like it's about to change the slide but then snaps back with mobile Firefox

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://shoelace.style/components/carousel on Firefox for Android
  2. Try to swipe to change slide

Browser / OS

  • OS: Android
  • Browser: Firefox
  • Browser version: latest
@acoreyj acoreyj added the bug Things that aren't working right in the library. label Dec 3, 2023
@alenaksu
Copy link
Collaborator

alenaksu commented Dec 4, 2023 •
edited
Loading

Hi @acoreyj, the pr #1748 should address the issues you've been experiencing with Firefox as well.
Here's the preview:
https://shoelace-git-alenaksu-fixios-scrollend-font-awesome.vercel.app/components/carousel

@acoreyj
Copy link
Author

acoreyj commented Dec 5, 2023

@alenaksu yes it is fixed in that preview!

@alenaksu alenaksu mentioned this issue Dec 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Things that aren't working right in the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(carousel): fix issues with safari shoelace-style/shoelace
2 participants
@acoreyj @alenaksu