Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip doesn't re-enable after disabling #391

Closed
brownieboy opened this issue Apr 1, 2021 · 1 comment
Closed

Tooltip doesn't re-enable after disabling #391

brownieboy opened this issue Apr 1, 2021 · 1 comment
Assignees
Labels
bug Things that aren't working right in the library.

Comments

@brownieboy
Copy link

Describe the bug
Adding the disabled property to the <sl-tooltip> disables the component correctly, but clearing that property does not then re-enable it.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://shoelace.style/components/tooltip
  2. Click on any <sl-tooltip> component in the browser dev tools, Elements tab
  3. Add the disabled attribute to its HTML, then remove that property
  4. See error. The tooltip is still disabled.

Expected behavior
If an <sl-tooltip> does not have the disabled property then it should be enabled.

Screenshots
shoelace-tooltip-does-not-reenable

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 89.0.4389.90 (Official Build) (64-bit)

Smartphone (please complete the following information):
n/a, not tested

@brownieboy brownieboy added the bug Things that aren't working right in the library. label Apr 1, 2021
@claviska
Copy link
Member

claviska commented Apr 1, 2021

Thanks for reporting this. The issue has been fixed in 3c9a481 and will be available in the next beta release.

claviska added a commit that referenced this issue Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library.
Projects
None yet
Development

No branches or pull requests

2 participants