Rubocop: Style/SafeNavigation #1518
Conversation
jaredmoody
force-pushed
the
robocop-style-safe-nav
branch
from
6b20d2a
to
6b6b211
Compare
| @@ -26,8 +26,7 @@ def pad_if_necessary(hex) | |||
| # Returns a 3- or 6-char hex string for valid input, or nil | |||
| # for invalid input. | |||
| def validate(hex) | |||
| match = /^#?(([0-9a-f]{3}){1,2})$/i.match(hex) | |||
| match && match[1] | |||
| /^#?(([0-9a-f]{3}){1,2})$/i.match(hex)&.[](1) | |||
There was a problem hiding this comment.
This is the only line of this PR I don't like - explicitly calling [] seems weird and perhaps unclear that it's equivalent
Alternatively, we could disable this cop on this line
There was a problem hiding this comment.
Agreed, that makes an already dense snippet even more obscure.
What's the cop say if we try to use a post-fix if instead?
match = /^#?(([0-9a-f]{3}){1,2})$/i.match(hex)
match[1] if match
There was a problem hiding this comment.
Could also move the regex into a constant imo :)
however yes, &.[](1) doesn't seem nice
| @@ -26,8 +26,7 @@ def pad_if_necessary(hex) | |||
| # Returns a 3- or 6-char hex string for valid input, or nil | |||
| # for invalid input. | |||
| def validate(hex) | |||
| match = /^#?(([0-9a-f]{3}){1,2})$/i.match(hex) | |||
| match && match[1] | |||
| /^#?(([0-9a-f]{3}){1,2})$/i.match(hex)&.[](1) | |||
There was a problem hiding this comment.
Could also move the regex into a constant imo :)
however yes, &.[](1) doesn't seem nice
jaredmoody
force-pushed
the
robocop-style-safe-nav
branch
from
6b6b211
to
4b608c3
Compare
|
Rubocop still complained on the Post-fix - updated with the regex pulled out into a constant and the cop disabled inline. |
|
Merge conflict now and soemhow a test failed but travis doesn't load for me |
jaredmoody
force-pushed
the
robocop-style-safe-nav
branch
from
4b608c3
to
87d67f4
Compare
|
Looking 🍏 now. Thanks! |
No description provided.