Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Ruby warnings #1567

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Resolve Ruby warnings #1567

merged 1 commit into from
Oct 3, 2018

Conversation

orien
Copy link
Contributor

@orien orien commented Oct 2, 2018 •
edited
Loading

Fixes #456

Resolves the following warnings as output in the CI build.

/home/travis/build/shoes/shoes4/shoes-core/lib/shoes/configuration.rb:40: warning: instance variable @backend_name not initialized
/home/travis/build/shoes/shoes4/shoes-core/lib/shoes/configuration.rb:42: warning: instance variable @backend not initialized

PragTob
PragTob approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@PragTob PragTob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👌

@PragTob PragTob merged commit 8336256 into shoes:master Oct 3, 2018
@orien orien deleted the resolve-warnings branch October 3, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragTob PragTob PragTob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orien @PragTob