Startup #187
Merged
Startup #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On OS X, using a ruby script required launching a new jruby process, in order to ensure we had the correct flags. Using a shell script, we only have to launch one jruby...faster startup.
|
Thanks for your quick work on this! I'm not quite sure though, but how does Windows cope with a shebang of sh? Does it at all? |
|
Windows uses |
|
Ah okay, of course - my bad! Looks good to me for all that I understand about shell script. As people already successfully tried it out I say good to merge :-) Thanks! |
PragTob
added a commit
that referenced
this pull request
Jan 9, 2013
Startup time improvements from @wasnotrice :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #186