Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scan_callback] Add scan_callback wrapper around scan method #29

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

dallaylaen
Copy link
Contributor

Handling cursor manually may be cumbersome, a callback interface simplifies scan() usage. See also

PerlRedis/perl-redis#170
PerlRedis/perl-redis#171

@dallaylaen
Copy link
Contributor Author

It looks like tests fail for this PR, did I do anything wrong?

Copy link
Owner

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shogo82148 shogo82148 merged commit 48f1a70 into shogo82148:main Dec 2, 2023
120 of 145 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants