MySQL 8.0.37 is released #1052
MySQL 8.0.37 is released #1052
Conversation
WalkthroughThe update involves upgrading MySQL from version "8.0.36" to "8.0.37" and includes adjustments to skip installing .pdb files for GitHub Actions due to their large size. Additionally, a patch reverts a specific commit related to bug fixes and refactors certain files in the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Files skipped from review due to trivial changes (1)
Additional comments not posted (3)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
patches/mysql/8.0.37/windows/revert-cce8da20cb5fc12e831a66e725fdc9c0c43ad7c6.patch (1)
162-225: Simplified tracing logic inclassic_stmt_execute_forwarder.ccmay reduce the granularity of debug information available.Consider adding conditional logging to provide more detailed trace information when needed.
| @@ -108,57 +108,4 @@ class ClassicFrame { | ||
| } | ||
| }; | ||
|
|
||
| -/** | ||
| - * receive a StmtExecute message from a channel. | ||
| - * | ||
| - * specialization of recv_msg<> as StmtExecute needs a the data from the | ||
| - * StmtPrepareOk. | ||
| - */ | ||
| -template <> | ||
| -inline stdx::expected<classic_protocol::borrowed::message::client::StmtExecute, | ||
| - std::error_code> | ||
| -ClassicFrame::recv_msg< | ||
| - classic_protocol::borrowed::message::client::StmtExecute>( | ||
| - Channel *src_channel, ClassicProtocolState *src_protocol, | ||
| - classic_protocol::capabilities::value_type caps) { | ||
| - using msg_type = classic_protocol::borrowed::message::client::StmtExecute; | ||
| - | ||
| - auto read_res = ClassicFrame::recv_frame_sequence(src_channel, src_protocol); | ||
| - if (!read_res) return stdx::make_unexpected(read_res.error()); | ||
| - | ||
| - const auto &recv_buf = src_channel->recv_plain_view(); | ||
| - | ||
| - auto frame_decode_res = classic_protocol::decode< | ||
| - classic_protocol::frame::Frame<classic_protocol::borrowed::wire::String>>( | ||
| - net::buffer(recv_buf), caps); | ||
| - if (!frame_decode_res) { | ||
| - return stdx::make_unexpected(frame_decode_res.error()); | ||
| - } | ||
| - | ||
| - src_protocol->seq_id(frame_decode_res->second.seq_id()); | ||
| - | ||
| - auto decode_res = classic_protocol::decode<msg_type>( | ||
| - net::buffer(frame_decode_res->second.payload().value()), caps, | ||
| - [src_protocol](auto stmt_id) | ||
| - -> stdx::expected<std::vector<msg_type::ParamDef>, std::error_code> { | ||
| - const auto it = src_protocol->prepared_statements().find(stmt_id); | ||
| - if (it == src_protocol->prepared_statements().end()) { | ||
| - return stdx::make_unexpected(make_error_code( | ||
| - classic_protocol::codec_errc::statement_id_not_found)); | ||
| - } | ||
| - | ||
| - std::vector<msg_type::ParamDef> params; | ||
| - params.reserve(it->second.parameters.size()); | ||
| - | ||
| - for (const auto ¶m : it->second.parameters) { | ||
| - params.emplace_back(param.type_and_flags); | ||
| - } | ||
| - | ||
| - return params; | ||
| - }); | ||
| - if (!decode_res) return stdx::make_unexpected(decode_res.error()); | ||
| - | ||
| - return decode_res->second; | ||
| -} | ||
| - | ||
| #endif |
There was a problem hiding this comment.
Removed detailed error handling and logging in classic_frame.h, which could impact debugging and error diagnostics.
+ // Restore detailed error handling and logging for better diagnostics
+ if (!decode_res) {
+ log_error("Decode failed with error: ", decode_res.error());
+ return stdx::make_unexpected(decode_res.error());
+ }Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| @@ -108,57 +108,4 @@ class ClassicFrame { | |
| } | |
| }; | |
| -/** | |
| - * receive a StmtExecute message from a channel. | |
| - * | |
| - * specialization of recv_msg<> as StmtExecute needs a the data from the | |
| - * StmtPrepareOk. | |
| - */ | |
| -template <> | |
| -inline stdx::expected<classic_protocol::borrowed::message::client::StmtExecute, | |
| - std::error_code> | |
| -ClassicFrame::recv_msg< | |
| - classic_protocol::borrowed::message::client::StmtExecute>( | |
| - Channel *src_channel, ClassicProtocolState *src_protocol, | |
| - classic_protocol::capabilities::value_type caps) { | |
| - using msg_type = classic_protocol::borrowed::message::client::StmtExecute; | |
| - | |
| - auto read_res = ClassicFrame::recv_frame_sequence(src_channel, src_protocol); | |
| - if (!read_res) return stdx::make_unexpected(read_res.error()); | |
| - | |
| - const auto &recv_buf = src_channel->recv_plain_view(); | |
| - | |
| - auto frame_decode_res = classic_protocol::decode< | |
| - classic_protocol::frame::Frame<classic_protocol::borrowed::wire::String>>( | |
| - net::buffer(recv_buf), caps); | |
| - if (!frame_decode_res) { | |
| - return stdx::make_unexpected(frame_decode_res.error()); | |
| - } | |
| - | |
| - src_protocol->seq_id(frame_decode_res->second.seq_id()); | |
| - | |
| - auto decode_res = classic_protocol::decode<msg_type>( | |
| - net::buffer(frame_decode_res->second.payload().value()), caps, | |
| - [src_protocol](auto stmt_id) | |
| - -> stdx::expected<std::vector<msg_type::ParamDef>, std::error_code> { | |
| - const auto it = src_protocol->prepared_statements().find(stmt_id); | |
| - if (it == src_protocol->prepared_statements().end()) { | |
| - return stdx::make_unexpected(make_error_code( | |
| - classic_protocol::codec_errc::statement_id_not_found)); | |
| - } | |
| - | |
| - std::vector<msg_type::ParamDef> params; | |
| - params.reserve(it->second.parameters.size()); | |
| - | |
| - for (const auto ¶m : it->second.parameters) { | |
| - params.emplace_back(param.type_and_flags); | |
| - } | |
| - | |
| - return params; | |
| - }); | |
| - if (!decode_res) return stdx::make_unexpected(decode_res.error()); | |
| - | |
| - return decode_res->second; | |
| -} | |
| - | |
| #endif | |
| @@ -108,57 +108,4 @@ class ClassicFrame { | |
| } | |
| }; | |
| #endif |
Summary by CodeRabbit
mysql_protocolmodule.