Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swap&indent lines / blocks #19

Closed
shokai opened this issue Apr 19, 2016 · 6 comments
Closed

swap&indent lines / blocks #19

shokai opened this issue Apr 19, 2016 · 6 comments
Labels
enhancement

Comments

@shokai
Copy link
Owner

shokai commented Apr 19, 2016 •
edited
Loading

ctrl+up/down - swap lines
shift+up/down - swap blocks
shift+left/right - indent
shokai added a commit that referenced this issue Apr 20, 2016
@shokai
swap lines with ctrl+up/down #19
f789788
@shokai
Copy link
Owner Author

shokai commented Apr 20, 2016

display indent by space prefix

@shokai shokai changed the title swap lines / blocks swap&indent lines / blocks Apr 20, 2016
@shokai
Copy link
Owner Author

shokai commented Apr 20, 2016 •
edited
Loading

indentは行頭スペースではなくindentプロパティを持たせた方が良いと思う
どうせ後で行ごとに誰が編集したかを保持するし #22

shokai added a commit that referenced this issue Apr 20, 2016
@shokai
display indent #19
e163409
shokai added a commit that referenced this issue Apr 20, 2016
@shokai
indent increment/decrement #19
50a9d6f
@shokai
Copy link
Owner Author

shokai commented Apr 20, 2016 •
edited
Loading

line schema

{
  value: "string",
  indent: number,
  user: userId
}

shokai added a commit that referenced this issue Apr 20, 2016
@shokai
changed Line from string to object - {value:String, indent:number} #19
f91550f
@shokai
Copy link
Owner Author

shokai commented Apr 20, 2016 •
edited
Loading

lineが複雑なObjectになったので、diffで保存する部分がやはりだめなようだ
#20 の実装が必要

shokai added a commit that referenced this issue Apr 20, 2016
@shokai
use clone npm #19
384be19
shokai added a commit that referenced this issue Apr 20, 2016
@shokai
server-side: changed Line from string to object #19
2f969ac
shokai added a commit that referenced this issue Apr 20, 2016
@shokai
send page data on swapline/indent #19
6b8330a
@shokai
Copy link
Owner Author

shokai commented Apr 20, 2016

cloneをまともな実装に入れ替えたらちゃんと（lineがstringだった頃と同程度に）保存が動くようになった
https://www.npmjs.com/package/clone

shokai added a commit that referenced this issue Apr 20, 2016
@shokai
indent block with shift+left/right #19
1e058a0
shokai added a commit that referenced this issue Apr 21, 2016
@shokai
rename swapline -> swapLine #19
40b7b2e
shokai added a commit that referenced this issue Apr 21, 2016
@shokai
add function getBlock(lines, start, func) for indent #19
760f7e1
shokai added a commit that referenced this issue Apr 21, 2016
@shokai
bugfix getBlock #19
caac053
shokai added a commit that referenced this issue Apr 21, 2016
@shokai
swap blocks with shift+up/down #19
e45c16f
shokai added a commit that referenced this issue Apr 21, 2016
@shokai
changed Line from string to object - {value:String, indent:number} #19
0f258e0 
use clone npm  #19
shokai added a commit that referenced this issue Apr 21, 2016
@shokai
send page data on swapline/indent #19
c86c8bc
shokai added a commit that referenced this issue Apr 21, 2016
@shokai
indent block with shift+left/right #19
88cc185
shokai added a commit that referenced this issue Apr 21, 2016
@shokai
rename swapline -> swapLine #19
7a92860
shokai added a commit that referenced this issue Apr 21, 2016
@shokai
add function getBlock(lines, start, func) for indent #19
18a822d
shokai added a commit that referenced this issue Apr 21, 2016
@shokai
swap blocks with shift+up/down #19
18cfefd
@shokai
Copy link
Owner Author

shokai commented Apr 21, 2016 •
edited
Loading

  • 行頭でのスペースキー、バックスペースキーでindent
  • insertNewLineした時に元の行のindentを引き継ぐ

shokai added a commit that referenced this issue Apr 21, 2016
@shokai
use same indent as previous line at "insertNewLine" action #19
cd993e9
shokai added a commit that referenced this issue Apr 21, 2016
@shokai
indent with space/backspace keys #19
980af4a
@shokai shokai closed this as completed Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shokai