Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate page name #7

Closed
shokai opened this issue Apr 10, 2016 · 2 comments
Closed

validate page name #7

shokai opened this issue Apr 10, 2016 · 2 comments
Labels
enhancement

Comments

@shokai
Copy link
Owner

shokai commented Apr 10, 2016 •
edited
Loading

invalid charcters

  • # \r \n
  • / in wikiname
  • url encoded chars
  • space on head/tail

valid

  • ?
  • a-zA-Z0-9_

reserved words

  • auth
  • login
  • logout
  • api
  • config
@shokai
Copy link
Owner Author

shokai commented Apr 19, 2016 •
edited
Loading

npmのpackagenameで使われている、URL friendlyな文字列かどうかの判定が参考になりそう
https://github.com/npm/validate-npm-package-name
https://github.com/npm/validate-npm-package-name/blob/master/index.js

@shokai shokai mentioned this issue Apr 19, 2016
Closed
@shokai
Copy link
Owner Author

shokai commented Apr 24, 2016 •
edited
Loading

validatorはできたので

  • mongooseのvalidator
  • clientでのroute action
  • wiki syntaxで禁止ページへのリンクを作らない

やってみよう

shokai added a commit that referenced this issue Apr 24, 2016
@shokai
add Route validator - check wiki & title #7
c709bdd
shokai added a commit that referenced this issue Apr 24, 2016
@shokai
set wiki&title validator at mongoose schema #7
a7cb009
shokai added a commit that referenced this issue Apr 24, 2016
@shokai
add validateRoute({wiki, title}) #7
e82f5c2
shokai added a commit that referenced this issue Apr 24, 2016
@shokai
validate wiki&title before set cache #7
4556c2c
shokai added a commit that referenced this issue Apr 24, 2016
@shokai
add redux middleware "validateOnRoute" #7
1985508
shokai added a commit that referenced this issue Apr 24, 2016
@shokai
validate in parseRoute function. modified default title "test" -> "he…
c102a75 
…llo" #7
shokai added a commit that referenced this issue Apr 24, 2016
@shokai
not create link to invalid wiki/title #7
ac6bf91
@shokai shokai closed this as completed Apr 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shokai