Skip to content

Commit

Permalink
fix: Fix production github actions (#505)
Browse files Browse the repository at this point in the history
  • Loading branch information
amaury1093 authored Mar 21, 2020
1 parent 10adffb commit b44fa30
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ env:
jobs:
# Publish to the current production release channel
expo-production-publish:
if: startsWith(github.ref, 'refs/heads/production-v')
if: startsWith(github.ref, 'refs/heads/production-v') # On production-v* branches
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
Expand All @@ -47,7 +47,7 @@ jobs:

# Build native binaries for testing or uploading to store
expo-production-binaries:
if: startsWith(github.ref, 'refs/heads/v')
if: startsWith(github.ref, 'refs/tags/v') # On v* tags
strategy:
matrix:
build: [ios, android-apk, android-app-bundle]
Expand All @@ -74,7 +74,7 @@ jobs:
- run: yarn install
- name: Set GITHUB_TAG
id: vars
run: echo ::set-output name=GITHUB_TAG::${GITHUB_REF:10} # Remove /refs/head/
run: echo ::set-output name=GITHUB_TAG::${GITHUB_REF:10} # Remove /refs/tags/
- name: Generate production app.json
run: ./scripts/generateAppJson.js
- run: expo ${{ matrix.expo_build_command }} --release-channel=production-${{ steps.vars.outputs.GITHUB_TAG }}
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ This app is bootstrapped with [Expo](https://expo.io), you can download the Expo

| Release Channel | Version | Description | Url |
| --------------------------------------------------------------------------------------------- | ------- | --------------------------------------------------------------------------- | --------------------------------------------------------------------------------- |
| [Production](https://exp.host/@amaurymartiny/shoot-i-smoke?release-channel=production-v1.5.6) | v1.5.6 | Same version as Sh\*\*t! I Smoke on the App Store and Play Store. | `https://exp.host/@amaurymartiny/shoot-i-smoke?release-channel=production-v1.5.6` |
| [Staging](https://exp.host/@amaurymartiny/shoot-i-smoke) | v1.5.6 | Latest version currently in development: newest features, may contain bugs. | `https://exp.host/@amaurymartiny/shoot-i-smoke` |
| [Production](https://exp.host/@amaurymartiny/shoot-i-smoke?release-channel=production-v1.5.7) | v1.5.7 | Same version as Sh\*\*t! I Smoke on the App Store and Play Store. | `https://exp.host/@amaurymartiny/shoot-i-smoke?release-channel=production-v1.5.7` |
| [Staging](https://exp.host/@amaurymartiny/shoot-i-smoke) | v1.5.7 | Latest version currently in development: newest features, may contain bugs. | `https://exp.host/@amaurymartiny/shoot-i-smoke` |

## :hammer: Build it yourself

Expand Down
4 changes: 2 additions & 2 deletions app.example.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
},
"icon": "assets/logos/ios/iTunesArtwork@3x.png",
"ios": {
"buildNumber": "1.5.6",
"buildNumber": "1.5.7",
"bundleIdentifier": "com.shitismoke.app",
"config": {
"googleMapsApiKey": "YOUR_OPTIONAL_KEY"
Expand All @@ -56,6 +56,6 @@
"backgroundColor": "#EBE7DD",
"image": "assets/logos/splash.png"
},
"version": "1.5.6"
"version": "1.5.7"
}
}

0 comments on commit b44fa30

Please sign in to comment.