Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quantity picker improvements #1114

Merged
merged 10 commits into from
Aug 9, 2021
Merged

Quantity picker improvements #1114

merged 10 commits into from
Aug 9, 2021

Conversation

AienTech
Copy link
Contributor

@AienTech AienTech commented Aug 4, 2021

Description

  • add a new property for custom QP label
  • lower the gap and remove the top margin of the QP wrapper
  • replace the QP label inside of the component
  • edit the UnitQuantityPicker.jsx to match the new styling

Type of change

Please add an "x" into the option that is relevant:

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

How to test it

Please describe here any specialty that the tester should be aware of.

@AienTech
CCP-2464:
d92f05b 
- add a new property for custom QP label
- lower the gap and remove the top margin of the QP wrapper
- replace the QP label inside of the component
- edit the UnitQuantityPicker.jsx to match the new styling
@AienTech AienTech added the enhancement New feature or request label Aug 4, 2021
@AienTech AienTech requested a review from Carsten89 August 4, 2021 17:42
@AienTech AienTech self-assigned this Aug 4, 2021
@AienTech
CCP-2464:
57fe7c4 
- use a custom property label to select the correct product property value for custom quantity label
@AienTech AienTech requested a review from Carsten89 August 4, 2021 20:38
@AienTech
CCP-2464:
5e1d2ea 
- get current product product properties from a selector
@AienTech AienTech requested a review from Carsten89 August 5, 2021 14:14
@AienTech
CCP-2464:
6c2d6b0 
- refactor the selector
@AienTech AienTech requested a review from Carsten89 August 5, 2021 17:06
@AienTech
CCP-2464:
c26f49c 
- refactor the selector
- improve the styles
- add showLabel option to theme configs
@AienTech
CCP-2464:
d8cb0a2 
- full width quantity picker
@AienTech
CCP-2464:
e60f82f 
- style fixes for orderQuantityHint component
@AienTech
CCP-2464:
41f8078 
- remove CartUnitQuantityPicker.jsx
- add configs to gmd theme
- fix variable naming issue
- change UnitQuantityPicker.jsx holder to div instead of span
@AienTech
CCP-2464:
357ad9d 
- remove inline styling for qty wrapper
@AienTech
CCP-2464:
5b96fbd 
- update tests
@Carsten89 Carsten89 merged commit 1f3a19a into v6.16.3 Aug 9, 2021
@Carsten89 Carsten89 deleted the CCP-2464-quantity-picker-improvements branch August 9, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carsten89 Carsten89 Carsten89 approved these changes

Assignees

@AienTech AienTech

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AienTech @Carsten89