Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA-444 optomize category and search #265

Merged
merged 6 commits into from
Sep 14, 2018
Merged

PWA-444 optomize category and search #265

merged 6 commits into from
Sep 14, 2018

Conversation

devbucket
Copy link
Contributor

No description provided.

@devbucket devbucket added the enhancement New feature or request label Sep 14, 2018
@devbucket devbucket self-assigned this Sep 14, 2018
@coveralls
Copy link

coveralls commented Sep 14, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 895

  • 6 of 9 (66.67%) changed or added relevant lines in 2 files are covered.
  • 65 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.5%) to 33.188%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/common/store/index.js 5 8 62.5%
Files with Coverage Reduction New Missed Lines %
themes/gmd/pages/Category/components/Products/connector.js 1 66.67%
libraries/commerce/filter/selectors/index.js 2 15.18%
themes/gmd/components/View/context.js 2 0.0%
themes/gmd/pages/Category/components/Empty/selectors.js 4 6.25%
themes/gmd/pages/RootCategory/connector.js 4 0.0%
themes/gmd/pages/Category/components/Content/connector.js 5 18.18%
themes/gmd/pages/Filter/components/Content/connector.js 6 0.0%
libraries/common/selectors/router.js 6 37.74%
libraries/commerce/category/selectors/index.js 16 19.74%
libraries/commerce/product/selectors/product.js 19 86.94%
Totals Coverage Status
Change from base Build 893: -0.5%
Covered Lines: 3908
Relevant Lines: 11660
💛 - Coveralls

richardgorman
richardgorman suggested changes Sep 14, 2018
View reviewed changes
Copy link
Contributor

@richardgorman richardgorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See code comments

@richardgorman richardgorman merged commit 21e9e8a into PWA-327-Exchange-Router Sep 14, 2018
@richardgorman richardgorman deleted the PWA-444-optomize-category-and-search branch September 14, 2018 14:39
SG-Noxoreos pushed a commit that referenced this pull request Oct 30, 2018
@fkloes
Merge pull request #265 from shopgate/PWA-739-description-links-z-index
f375e76 
PWA-739: Fixed layering issue at product description links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardgorman richardgorman richardgorman approved these changes

Assignees

@devbucket devbucket

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devbucket @coveralls @richardgorman