Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The checkout bar is only disabled once when the cart is busy. #312

Conversation

devbucket
Copy link
Contributor

Description

When an item in the cart is manipulated, added or deleted, the cart needs to sync with the shopgate-connect. While this happens, the checkout bar is disabled once and only enabled when all synching actions have finished.

Type of change

Please add an "x" into the option that is relevant:

  • [ x ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

How to test it

Put any products or coupons in the cart, visit the cart page and start changing stuff.

@devbucket devbucket added the bug Something isn't working label Oct 10, 2018
@devbucket devbucket self-assigned this Oct 10, 2018
@coveralls
Copy link

coveralls commented Oct 10, 2018

Pull Request Test Coverage Report for Build 1127

  • 0 of 7 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 35.573%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/commerce/cart/subscriptions/index.js 0 2 0.0%
libraries/core/classes/BrowserConnector/index.js 0 5 0.0%
Totals Coverage Status
Change from base Build 1125: -0.02%
Covered Lines: 4115
Relevant Lines: 11664

💛 - Coveralls

@richardgorman richardgorman merged commit e0b3f6d into PWA-327-Exchange-Router Oct 10, 2018
@richardgorman richardgorman deleted the PWA-1002-fix-disabling-of-checkout-button branch October 10, 2018 14:55
SG-Noxoreos pushed a commit that referenced this pull request Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants