Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted font, notification, navigator and buttons to match iOS style. #329

Merged
merged 8 commits into from
Oct 23, 2018

Conversation

devbucket
Copy link
Contributor

Type of change

Please add an "x" into the option that is relevant:

  • [ ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ x ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ x ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

@devbucket devbucket added the enhancement New feature or request label Oct 18, 2018
@devbucket devbucket self-assigned this Oct 18, 2018
@coveralls
Copy link

coveralls commented Oct 18, 2018

Pull Request Test Coverage Report for Build 1244

  • 8 of 13 (61.54%) changed or added relevant lines in 8 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 45.692%

Changes Missing Coverage Covered Lines Changed/Added Lines %
themes/theme-ios11/components/Viewport/style.js 0 1 0.0%
libraries/common/selectors/client.js 0 2 0.0%
themes/theme-gmd/components/Viewport/style.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
libraries/common/styles/reset/root.js 1 0.0%
libraries/common/selectors/client.js 13 18.37%
Totals Coverage Status
Change from base Build 1241: -0.2%
Covered Lines: 4746
Relevant Lines: 9775

💛 - Coveralls

>
<div className={styles.inner}>
{left}
{center}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bildschirmfoto 2018-10-18 um 16 31 51
The title is not centered anymore when there is no icon at the right position.
bildschirmfoto 2018-10-18 um 16 33 52
On the filters page the layout doesn't look nice

@fkloes fkloes merged commit 6a39452 into PWA-327-Exchange-Router Oct 23, 2018
@fkloes fkloes deleted the PWA-1089-Styling-Global-components branch October 23, 2018 15:45
SG-Noxoreos pushed a commit that referenced this pull request Oct 30, 2018
…-form

PWA-664 - no client validation for login form since browser validate …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants