Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed product images fallback for variants without own images #460

Merged
merged 2 commits into from
Dec 6, 2018

Conversation

fkloes
Copy link
Collaborator

@fkloes fkloes commented Dec 6, 2018

Description

This ticket is about to fix the product images fallback for product variants without images. In that case a gallery of the base product images should be shown if it has multiple images.

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • New Feature 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Docs 📝 (Changes in the documentations)
  • Internal 🏠 Only relates to internal processes.

How to test it

  • put a variant without own images into the cart
  • goto the cart and reload the page
  • open the product within the cart

Desired outcome:
You see a product image gallery with the images of the parent product.

@fkloes fkloes added the bug Something isn't working label Dec 6, 2018
@fkloes fkloes self-assigned this Dec 6, 2018
@devbucket devbucket merged commit 381b31c into v6.0.1 Dec 6, 2018
@devbucket devbucket deleted the PWA-1429-no-product-gallery-at-variants branch December 6, 2018 13:37
@coveralls
Copy link

coveralls commented Dec 8, 2018

Pull Request Test Coverage Report for Build 1715

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 47.13%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/commerce/product/subscriptions/index.js 0 1 0.0%
Totals Coverage Status
Change from base Build 1714: -0.004%
Covered Lines: 4843
Relevant Lines: 9705

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants