Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed opening of child products on favourite list #465

Merged
merged 2 commits into from
Dec 7, 2018
Merged

Fixed opening of child products on favourite list #465

merged 2 commits into from
Dec 7, 2018

Conversation

fkloes
Copy link
Collaborator

@fkloes fkloes commented Dec 7, 2018

Description

This ticket is about fixing opening of child products from the favourite list. Before the baseProductId was used to open the link if it was available. That caused that in any situation the parent product was opened for the user.

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • New Feature 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Docs 📝 (Changes in the documentations)
  • Internal 🏠 Only relates to internal processes.

@fkloes fkloes added the bug Something isn't working label Dec 7, 2018
@fkloes fkloes self-assigned this Dec 7, 2018
@devbucket devbucket merged commit 7beecfe into v6.0.1 Dec 7, 2018
@devbucket devbucket deleted the PWA-1437-child-products-on-favourite-list branch December 7, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbucket devbucket devbucket approved these changes

Assignees

@fkloes fkloes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fkloes @devbucket