Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some minor issues and hick-ups in the commerce selectors. #468

Merged
merged 11 commits into from
Dec 12, 2018

Conversation

devbucket
Copy link
Contributor

Description

To make it easier for every developer to access the bits and pieces in the commerce library, index files have been added to every feature library in commerce. Because of naming conflicts, some of the actions have been renamed from get... to fetch.... Additionally, missing default values in the selectors have been added.

Type of change

Please add an "x" into the option that is relevant:

  • [ ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ x ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

@devbucket devbucket self-assigned this Dec 10, 2018
@devbucket devbucket added the enhancement New feature or request label Dec 10, 2018
@coveralls
Copy link

coveralls commented Dec 10, 2018

Pull Request Test Coverage Report for Build 1752

  • 48 of 311 (15.43%) changed or added relevant lines in 65 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 46.225%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/commerce/cart/selectors/index.js 0 1 0.0%
libraries/commerce/category/actions/fetchCategoryProducts.js 0 1 0.0%
libraries/commerce/product/actions/fetchHighlightProducts.js 1 2 50.0%
libraries/commerce/reviews/actions/fetchProductReviews.js 11 12 91.67%
libraries/commerce/reviews/actions/fetchUserReview.js 9 10 90.0%
themes/theme-gmd/pages/Category/subscriptions.js 0 1 0.0%
themes/theme-gmd/pages/WriteReview/subscriptions.js 0 1 0.0%
themes/theme-gmd/widgets/Products/connector.js 0 1 0.0%
themes/theme-ios11/pages/Category/subscriptions.js 0 1 0.0%
themes/theme-ios11/pages/WriteReview/subscriptions.js 0 1 0.0%
Totals Coverage Status
Change from base Build 1750: -0.6%
Covered Lines: 4806
Relevant Lines: 9741

💛 - Coveralls

devbucket and others added 2 commits December 11, 2018 08:36
…nor-issues-and-hickups-in-selectors

# Conflicts:
#	themes/theme-ios11/pages/Search/subscriptions.spec.js
@fkloes fkloes merged commit e86680f into v6.1.0 Dec 12, 2018
@fkloes fkloes deleted the PWA-1456-fix-minor-issues-and-hickups-in-selectors branch December 12, 2018 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants