Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ProductSlider to the ThemeContext #492

Merged
merged 3 commits into from
Jan 14, 2019
Merged

Added ProductSlider to the ThemeContext #492

merged 3 commits into from
Jan 14, 2019

Conversation

richardgorman
Copy link
Contributor

  • [ ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ x ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

@richardgorman richardgorman added the enhancement New feature or request label Jan 14, 2019
@richardgorman richardgorman self-assigned this Jan 14, 2019
@coveralls
Copy link

coveralls commented Jan 14, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1836

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 46.003%
Changes Missing Coverage Covered Lines Changed/Added Lines %
themes/theme-gmd/themeApi/index.js 0 1 0.0%
themes/theme-ios11/themeApi/index.js 0 1 0.0%
Totals Coverage Status
Change from base Build 1835: -0.007%
Covered Lines: 4849
Relevant Lines: 9862
💛 - Coveralls

@devbucket devbucket changed the base branch from v6.1.0 to v6.2.0 January 14, 2019 15:33
@devbucket devbucket changed the title Pwa 1435 add product slider to theme context Added ProductSlider to the ThemeContext Jan 14, 2019
@devbucket devbucket merged commit 9ce6dcb into v6.2.0 Jan 14, 2019
@devbucket devbucket deleted the PWA-1435-Add-ProductSlider-to-ThemeContext branch January 14, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbucket devbucket devbucket approved these changes

Assignees

@richardgorman richardgorman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardgorman @coveralls @devbucket