Changed getPageConfig and getUser redux actions to fetch... to match the API #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1923
💛 - Coveralls |
|
I enabled |
alexbridge
approved these changes
Feb 1, 2019
| import { shouldFetchData } from '../../helpers/redux'; | ||
| import * as actions from '../../action-creators/page'; | ||
| import { getPageConfigById } from '../../selectors/page'; | ||
| import { fetchPageConfig } from './fetchPageConfig'; |
There was a problem hiding this comment.
fetchPageConfig has no named import fetchPageConfig. You need import it as default
| import * as pipelines from '../../constants/Pipelines'; | ||
| import * as actions from '../../action-creators/user'; | ||
| import { isUserLoggedIn } from '../../selectors/user'; | ||
| import { fetchUser } from './fetchUser'; |
There was a problem hiding this comment.
fetchUser has no named import fetchUser . You need import it as default
alexbridge
deleted the
PWA-1658-Rename-getUser-and-getPageConfig-actions-to-fetchX
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Those two functions haven't been renamed and were now changed to the new naming convention to match the API.
Type of change
Please add an "x" into the option that is relevant: