Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned up Portal positions #550

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Cleaned up Portal positions #550

merged 1 commit into from
Feb 25, 2019

Conversation

fkloes
Copy link
Collaborator

@fkloes fkloes commented Feb 25, 2019

Description

This ticket is about removing unused Portal constants and adding Portal positions which got lost during the implementation of PWA 6.0.

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • New Feature 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Docs 📝 (Changes in the documentations)
  • Internal 🏠 Only relates to internal processes.

@fkloes fkloes added the enhancement New feature or request label Feb 25, 2019
@fkloes fkloes self-assigned this Feb 25, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2063

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 47.317%
Totals Coverage Status
Change from base Build 2055: -0.02%
Covered Lines: 5057
Relevant Lines: 10022
💛 - Coveralls

@SG-Noxoreos SG-Noxoreos merged commit 97e1a45 into v6.3.0 Feb 25, 2019
@SG-Noxoreos SG-Noxoreos deleted the PWA-1736-clean-up-portals branch February 25, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SG-Noxoreos SG-Noxoreos SG-Noxoreos approved these changes

Assignees

@fkloes fkloes

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fkloes @coveralls @SG-Noxoreos