Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error behaviour for tracking core plugin calls #555

Merged
merged 5 commits into from
Feb 27, 2019
Merged

Conversation

alexbridge
Copy link
Contributor

@alexbridge alexbridge commented Feb 27, 2019

Description

Improve error behaviour for tracking core plugin calls

Type of change

Please add an "x" into the option that is relevant:

  • [ ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • Internal 🏠 Only relates to internal processes.

@devbucket devbucket added the enhancement New feature or request label Feb 27, 2019
@devbucket devbucket merged commit 8bb520e into v6.3.0 Feb 27, 2019
@devbucket devbucket deleted the PWA-1726 branch February 27, 2019 18:31
@coveralls
Copy link

coveralls commented Feb 28, 2019

Pull Request Test Coverage Report for Build 2100

  • 2 of 20 (10.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 47.073%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/tracking/subscriptions/setup.js 0 4 0.0%
libraries/common/subscriptions/error.js 0 7 0.0%
libraries/tracking-core/core/Core.js 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
libraries/common/subscriptions/error.js 1 0.0%
Totals Coverage Status
Change from base Build 2099: -0.06%
Covered Lines: 5066
Relevant Lines: 10100

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants