Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct handling of concurrent cart requests when adding a coupon with deeplink #556

Merged
merged 2 commits into from
Feb 28, 2019
Merged

Correct handling of concurrent cart requests when adding a coupon with deeplink #556

merged 2 commits into from
Feb 28, 2019

Conversation

alexbridge
Copy link
Contributor

Description

Correct handling of concurrent cart requests when adding a coupon with deeplink or push notification

Type of change

Please add an "x" into the option that is relevant:

  • [ X ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

@alexbridge alexbridge added the bug Something isn't working label Feb 28, 2019
@alexbridge alexbridge self-assigned this Feb 28, 2019
@devbucket devbucket merged commit b43bc39 into v6.3.0 Feb 28, 2019
@devbucket devbucket deleted the PWA-1729 branch February 28, 2019 16:11
@coveralls
Copy link

coveralls commented Mar 2, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2106

  • 1 of 3 (33.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 47.066%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/commerce/cart/subscriptions/index.js 0 2 0.0%
Totals Coverage Status
Change from base Build 2105: -0.007%
Covered Lines: 5066
Relevant Lines: 10102
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbucket devbucket devbucket approved these changes

Assignees

@alexbridge alexbridge

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexbridge @coveralls @devbucket