Restructured PaymentBar and added Portals around cart totals #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reworked totals layout to have multiple rows instead of a column with labels and one with amounts - added Portals around the totals section an each total row - unified the PaymentBar layout between the themes (gmd has now the ios layout)
Pull Request Test Coverage Report for Build 2132
💛 - Coveralls |
devbucket
approved these changes
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ticket contains some refactoring to be able to provide Portals to the totals within the PaymentBar component. Since the original layout was based on columns (one with the labels, one with the amounts), the totals section had to be changed. Now each total has an own row with surrounding Portals.
Additionally the general layout of the PaymentBar was unified. Now both themes use the layout of the iOS PaymentBar.
Type of change