Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to hide and replace the TabBar for the iOS theme #565

Merged
merged 3 commits into from
Mar 11, 2019

Conversation

alexbridge
Copy link
Contributor

Description

Add possibility to hide and replace the TabBar fir ios theme

Type of change

Please add an "x" into the option that is relevant:

  • [ ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ X ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

@alexbridge alexbridge added the enhancement New feature or request label Mar 8, 2019
@alexbridge alexbridge self-assigned this Mar 8, 2019
@coveralls
Copy link

coveralls commented Mar 8, 2019

Pull Request Test Coverage Report for Build 2142

  • 13 of 22 (59.09%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 47.117%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/common/collections/Configuration.js 4 13 30.77%
Totals Coverage Status
Change from base Build 2140: 0.02%
Covered Lines: 5091
Relevant Lines: 10133

💛 - Coveralls

@devbucket devbucket changed the title Add possibility to hide and replace the TabBar fir ios theme Add possibility to hide and replace the TabBar for the iOS theme Mar 8, 2019
@@ -35,15 +37,21 @@ class KeyboardConsumer extends PureComponent {
* Stores current keyboard state.
*/
handleKeyboardChange = ({ open, overlap, duration }) => {
// eslint-disable-next-line extra-rules/no-single-line-objects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the rules and don't deactivate them ;) There have been created for a good reason.

@devbucket devbucket merged commit a043d91 into v6.X Mar 11, 2019
@devbucket devbucket deleted the PWA-1689 branch March 11, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants