Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The routeDidChange$ stream is now an alias of routeDidEnter$ since it is already deprecated. #575

Merged
merged 2 commits into from
Mar 19, 2019
Merged

The routeDidChange$ stream is now an alias of routeDidEnter$ since it is already deprecated. #575

merged 2 commits into from
Mar 19, 2019

Conversation

devbucket
Copy link
Contributor

Type of change

Please add an "x" into the option that is relevant:

  • [ x ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

@devbucket devbucket added the bug Something isn't working label Mar 18, 2019
@devbucket devbucket self-assigned this Mar 18, 2019
@devbucket devbucket changed the title The routeDidChange$ is now an alias of routeDidEnter$ since it is already deprecated. The routeDidChange$ is now an alias of routeDidEnter$ since it is already deprecated. Mar 18, 2019
@devbucket devbucket changed the title The routeDidChange$ is now an alias of routeDidEnter$ since it is already deprecated. The routeDidChange$ stream is now an alias of routeDidEnter$ since it is already deprecated. Mar 18, 2019
@coveralls
Copy link

coveralls commented Mar 18, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2162

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 47.23%
Totals Coverage Status
Change from base Build 2161: 0.0%
Covered Lines: 5087
Relevant Lines: 10104
💛 - Coveralls

@alexbridge alexbridge merged commit e78c637 into v6.X Mar 19, 2019
@alexbridge alexbridge deleted the PWA-1671-routDidChange$-is-not-working-correctly branch March 19, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbridge alexbridge alexbridge approved these changes

Assignees

@devbucket devbucket

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devbucket @coveralls @alexbridge