Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a camera permission check before the scanner route is opened #597

Merged
merged 6 commits into from
Apr 4, 2019

Conversation

fkloes
Copy link
Collaborator

@fkloes fkloes commented Apr 3, 2019

Description

This ticket is about to "protect" the scanner route with a camera permission check. So when the route is opened, and the permissions are not granted yet, we'll present a dialog to the user where he can directly grant permissions - if possible -, or first navigate to the settings.

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • New Feature 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Docs 📝 (Changes in the documentations)
  • Internal 🏠 Only relates to internal processes.

How to test it

Open a fresh installed app, or revoke the camera permissions for one that is already installed. Try to navigate to the scanner page.

To test the full feature, you'll need an app, that supports the new scanner. But since the permission commands exist since Lib 18.0, you could also add a link to the scanner route with a HTML widget.

@fkloes fkloes added the enhancement New feature or request label Apr 3, 2019
@fkloes fkloes self-assigned this Apr 3, 2019
@coveralls
Copy link

coveralls commented Apr 3, 2019

Pull Request Test Coverage Report for Build 2298

  • 28 of 50 (56.0%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 50.869%

Changes Missing Coverage Covered Lines Changed/Added Lines %
themes/theme-gmd/pages/subscriptions.js 0 11 0.0%
themes/theme-ios11/pages/subscriptions.js 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
themes/theme-gmd/pages/subscriptions.js 1 0.0%
themes/theme-ios11/pages/subscriptions.js 1 0.0%
Totals Coverage Status
Change from base Build 2296: 0.05%
Covered Lines: 5716
Relevant Lines: 10636

💛 - Coveralls

@alexbridge alexbridge merged commit 4ad2256 into v6.X Apr 4, 2019
@alexbridge alexbridge deleted the PWA-1788-camera-permissions branch April 4, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants