Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced @shopgate/engage package to start new API #598

Merged
merged 13 commits into from
Apr 4, 2019

Conversation

devbucket
Copy link
Contributor

Type of change

Please add an "x" into the option that is relevant:

  • [ ] Bug Fix 🐛 (non-breaking change which fixes an issue)
  • [ x ] New Feature 🚀 (non-breaking change which adds functionality)
  • [ ] Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Polish 💅 (Just some cleanups)
  • [ ] Docs 📝 (Changes in the documentations)
  • [ ] Internal 🏠 Only relates to internal processes.

How to test it

Please describe here any specialty that the tester should be aware of.

@devbucket devbucket added the enhancement New feature or request label Apr 3, 2019
@devbucket devbucket self-assigned this Apr 3, 2019
@coveralls
Copy link

coveralls commented Apr 3, 2019

Pull Request Test Coverage Report for Build 2320

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 50.969%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/commerce/checkout/index.js 0 1 0.0%
libraries/commerce/scanner/index.js 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
libraries/commerce/product/action-creators/setProductVariantId.js 2 0.0%
libraries/commerce/product/action-creators/setProductId.js 2 0.0%
libraries/commerce/product/actions/processProductFlags.js 6 0.0%
Totals Coverage Status
Change from base Build 2305: 0.1%
Covered Lines: 5729
Relevant Lines: 10625

💛 - Coveralls

@fkloes fkloes merged commit 534704d into v6.X Apr 4, 2019
@fkloes fkloes deleted the PWA-1754-add-shopgate-engage-package branch April 4, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants