Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to null when no shipping is given #600

Merged
merged 3 commits into from
Apr 4, 2019
Merged

Fallback to null when no shipping is given #600

merged 3 commits into from
Apr 4, 2019

Conversation

alexbridge
Copy link
Contributor

@alexbridge alexbridge commented Apr 4, 2019 •
edited by SG-Noxoreos
Loading

Description

Fallback to null when no shipping is given

Type of change

Please add an "x" into the option that is relevant:

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • New Feature 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Docs 📝 (Changes in the documentations)
  • Internal 🏠 Only relates to internal processes.

@alexbridge alexbridge added the bug Something isn't working label Apr 4, 2019
@alexbridge alexbridge self-assigned this Apr 4, 2019
@coveralls
Copy link

coveralls commented Apr 4, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2332

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.952%
Totals Coverage Status
Change from base Build 2328: 0.0%
Covered Lines: 5729
Relevant Lines: 10626
💛 - Coveralls

@SG-Noxoreos SG-Noxoreos merged commit 6994714 into v6.X Apr 4, 2019
@SG-Noxoreos SG-Noxoreos deleted the PWA-1826 branch April 4, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SG-Noxoreos SG-Noxoreos SG-Noxoreos approved these changes

Assignees

@alexbridge alexbridge

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexbridge @coveralls @SG-Noxoreos