Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open social media app deeplinks natively #604

Merged
merged 3 commits into from
Apr 5, 2019
Merged

Open social media app deeplinks natively #604

merged 3 commits into from
Apr 5, 2019

Conversation

alexbridge
Copy link
Contributor

Description

Open social media app deeplinks natively

Type of change

Please add an "x" into the option that is relevant:

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

How to test it

Please describe here any specialty that the tester should be aware of.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2344

  • 6 of 8 (75.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 47.016%

Changes Missing Coverage Covered Lines Changed/Added Lines %
themes/theme-gmd/widgets/Html/connector.js 0 1 0.0%
themes/theme-ios11/widgets/Html/connector.js 0 1 0.0%
Totals Coverage Status
Change from base Build 2343: 0.04%
Covered Lines: 5072
Relevant Lines: 10125

💛 - Coveralls

@alexbridge alexbridge added the bug Something isn't working label Apr 5, 2019
@alexbridge alexbridge self-assigned this Apr 5, 2019
@fkloes fkloes merged commit bbcfc8b into v6.3.2 Apr 5, 2019
@fkloes fkloes deleted the PWA-1792-632 branch April 5, 2019 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants