Added support for videos on the Product Detail Page #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deo-pdp # Conflicts: # extensions/@shopgate-theme-config/frontend/config-common.js # libraries/commerce/product/constants/index.js # libraries/engage/components/index.js # libraries/engage/product/index.js # themes/theme-gmd/components/ProductCard/index.jsx # themes/theme-ios11/components/ProductCard/index.jsx
devbucket
changed the title
devbucket
suggested changes
May 20, 2019
themes/theme-gmd/pages/ProductGallery/components/Content/components/ImagesSlider/index.jsx
Outdated
Show resolved
Hide resolved
themes/theme-ios11/pages/ProductGallery/components/Content/components/ImagesSlider/index.jsx
Outdated
Show resolved
Hide resolved
themes/theme-ios11/pages/ProductGallery/components/Content/components/MediaSlider/index.jsx
Outdated
Show resolved
Hide resolved
alexbridge
force-pushed
the
PWA-1897-support-video-pdp
branch
from
ad9d4a3
to
438a74d
Compare
devbucket
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We added support for videos in the image slider on the Product Detail Page.
Type of change
Please add an "x" into the option that is relevant: