Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed NavDrawer Header update when user name was updated #676

Merged
merged 3 commits into from
May 28, 2019
Merged

Fixed NavDrawer Header update when user name was updated #676

merged 3 commits into from
May 28, 2019

Conversation

fkloes
Copy link
Collaborator

@fkloes fkloes commented May 27, 2019

Description

This ticket fixes and issue where the Header sub component of the NavDrawer didn't update, when the user name changed within the store.

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

How to test it

Dispatch the RECEIVE_USER action with different names, and check if the NavDrawer Header updates.

@fkloes fkloes added the bug Something isn't working label May 27, 2019
@fkloes fkloes self-assigned this May 27, 2019
@alexbridge alexbridge merged commit 02d4acc into v6.5.1 May 28, 2019
@alexbridge alexbridge deleted the PWA-1648-account-data-does-not-update-properly branch May 28, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbridge alexbridge alexbridge approved these changes

Assignees

@fkloes fkloes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fkloes @alexbridge