Introduced a global translation helper #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… implementation of theme translations
sznowicki
changed the title
alexbridge
previously requested changes
Jun 19, 2019
…t is warned with deprecation console warning
… unit tests environment as before
|
Updated feature branch with |
SG-Noxoreos
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@shopgate/engage/core exports i18n module which is pure js implementation of theme translations
Type of change
Please add an "x" into the option that is relevant:
How to test it
There is an example extension created for showcase purposes which contains first implementation of the feature.
https://github.com/shopgate-professional-services/engage-translations-demo