Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved general navigation for screen readers #702

Merged
merged 6 commits into from
Jun 19, 2019

Conversation

fkloes
Copy link
Collaborator

@fkloes fkloes commented Jun 17, 2019

Description

This ticket is about to improve the general navigation for screen readers at both themes. It introduces a main menu which is only accessible via a screen reader. Additionally it introduces auto focus at the navigation bar on forward navigation, and it highlights the two content sections of category pages.

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

…heme

- added hidden navigation menu
- hidden TabBar from screen readers
- auto focus for the back button on forward navigation
- added a11y sections to the category page
- improved visibility of engage/core hocs in the developer tools
@fkloes fkloes added the enhancement New feature or request label Jun 17, 2019
@fkloes fkloes self-assigned this Jun 17, 2019
libraries/common/selectors/router.js Show resolved Hide resolved
libraries/engage/a11y/index.spec.js Show resolved Hide resolved
@SG-Noxoreos SG-Noxoreos merged commit 8223890 into v6.7.0 Jun 19, 2019
@SG-Noxoreos SG-Noxoreos deleted the PWA-1980-accessibility-basic-navigation branch June 19, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants