Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added empty data check to getKnownRelatives selector #769

Merged
merged 3 commits into from
Jul 15, 2019
Merged

Conversation

Carsten89
Copy link
Contributor

Description

Added empty data check to getKnownRelatives selector. So it doesn't throw an error if the product data are not there yet

Type of change

Please add an "x" into the option that is relevant:

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

@Carsten89 Carsten89 added the bug Something isn't working label Jul 12, 2019
@Carsten89 Carsten89 self-assigned this Jul 12, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2906

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0001%) to 50.913%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/commerce/product/selectors/variants.js 1 2 50.0%
Totals Coverage Status
Change from base Build 2905: -0.0001%
Covered Lines: 10032
Relevant Lines: 18665

💛 - Coveralls

@alexbridge alexbridge merged commit 5f4e77d into v6.7.0 Jul 15, 2019
@alexbridge alexbridge deleted the PWA-2136 branch July 15, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants