PWA-465 pdp implement the image slider #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,6 +3,7 @@ import { | |||
| routeDidLeave, | |||
| } from '@shopgate/pwa-common/streams/history'; | |||
| import { getRedirectLocation } from '@shopgate/pwa-common/selectors/history'; | |||
| import setViewTitle from '@shopgate/pwa-common/action-creators/view/setViewTitle'; | |||
There was a problem hiding this comment.
Please use the setTitle action
| @@ -47,6 +49,11 @@ function product(subscribe) { | |||
| dispatch(setProductVariantId(null)); | |||
| } | |||
| }); | |||
|
|
|||
| subscribe(productReceived$, ({ dispatch, action }) => { | |||
There was a problem hiding this comment.
The title should only be set if the user is still on the product page with the received id.
| import PropTypes from 'prop-types'; | ||
| import portalCollection from '../../helpers/portals/portalCollection'; | ||
| import { componentsConfig as config } from '../../helpers/config'; | ||
|
|
||
| /** | ||
| * The Portal component. | ||
| */ | ||
| class Portal extends Component { | ||
| class Portal extends PureComponent { |
…-Implement-the-ImageSlider
…-Implement-the-ImageSlider
| @@ -239,7 +239,7 @@ const getProductImagesState = state => state.product.imagesByProductId; | |||
| * @return {Array|null} | |||
| */ | |||
| export const getProductImages = createSelector( | |||
| getCurrentProductId, | |||
| (state, props) => props.productId, | |||
| getCurrentBaseProductId, | |||
There was a problem hiding this comment.
This selector needs to be changed to not rely on a product id stored in Redux
added 4 commits
June 6, 2018 18:19
richardgorman
approved these changes
Jun 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.