Improved extensibility of CTA button portals #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- optimized component styles of the Media and ProductHeader components to avoid flickering of CTA buttons on iOS 13 devices
devbucket
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ticket solves and issue at the PDP on iOS 13 devices. When additional buttons where added to the CTA button Portals, they flickered when the user scrolled the page.
We already tried to fix the issue earlier, but applied the optimization only to the buttons within the main Portal. The new approach from this PR applies to the fix to the Media components, instead of the CTAButton component.
Type of change
How to test it
Checkout and attach the ext-pdp-native-share extension and open a PDP on an iOS 13 device. Scroll a little bit and check if the CTA buttons are still flickering.