Added JSON schema definition for the theme configuration. #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkloes
requested changes
Dec 12, 2019
There was a problem hiding this comment.
You've implemented a general schema. This might fit right now since the themes have the same foundation. I think that we need a schema for each theme, since they might differ in the future. Additionally we might open the validation system also for extensions. So i think, the file should be located near the extension-config files which are used to generate the views for the settings section of the NMA.
The schema also just covers the theme property inside of the extension / theme config. But it think the issue which we want to solve here will also exist for the other settings inside of the config.
fkloes
approved these changes
Dec 17, 2019
devbucket
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to be able to validate the theme configuration, we added a JSON schema definition.
Type of change
Please add an "x" into the option that is relevant:
How to test it
Copy the content of the theme-config.schema.json file into this UI: https://rjsf-team.github.io/react-jsonschema-form/ - here you can test the validation by either filling in the UI fields or filling JSON object in the formData section.