Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compression codec flag set incorrectly #20

Closed
eapache opened this issue Aug 21, 2013 · 0 comments · Fixed by #21
Closed

Compression codec flag set incorrectly #20

eapache opened this issue Aug 21, 2013 · 0 comments · Fixed by #21
Labels
protocol

Comments

@eapache
Copy link
Contributor

eapache commented Aug 21, 2013

I will have to write a test to verify this, but I think #8 introduced a bug. The contents of the message is correctly compressed, but the flag indicating the compression codec used is no longer set properly in the outgoing message.

(CC @burke @fw42 )
eapache pushed a commit that referenced this issue Aug 22, 2013
Fix message compression flag.
013a53b 
Fixes #20.

Pull request #8 introduced a bug where the flag indicating which compression
format was used wouldn't be correctly set in the outgoing message. Instead of
overriding the Value field (which would also be confusing for people trying to
use it after sending) we cache the compressed payload in a separate hidden
field, and don't change the compression flags.

Add some tests to ensure this doesn't happen again.

Bonus fix: error if we don't recognize the compression format.
@eapache eapache mentioned this issue Aug 22, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix message compression flag. IBM/sarama
1 participant
@eapache