Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] shopinvader_mass_mailing 📨 #1108

Closed

Conversation

ivantodorovich
Copy link
Contributor

Exposes a mailing lists service to allow visitors to subscribe / unsubscribe from them.

@ivantodorovich ivantodorovich force-pushed the 14.0-add-mass-mailing branch 5 times, most recently from e0c514d to 68581ba Compare September 21, 2021 18:58
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall

shopinvader_mass_mailing/services/mailing_list.py Outdated Show resolved Hide resolved
shopinvader_mass_mailing/services/mailing_list.py Outdated Show resolved Hide resolved
shopinvader_mass_mailing/tests/common.py Outdated Show resolved Hide resolved
@ivantodorovich
Copy link
Contributor Author

Done!

Tests are failing due to openupgradelib though:

  Running command git clone -q https://github.com/OCA/openupgradelib.git /tmp/pip-install-gcz7x0j0/openupgradelib_9d8187731d0046faba61f12ced52508d
  Cloning https://github.com/OCA/openupgradelib.git to /tmp/pip-install-gcz7x0j0/openupgradelib_9d8187731d0046faba61f12ced52508d
  Resolved https://github.com/OCA/openupgradelib.git to commit 871058afeb6dbd9b34314108b4a8ca6f3e0a9d9f
    ERROR: Command errored out with exit status 1:
     command: /opt/odoo-venv/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-gcz7x0j0/openupgradelib_9d8187731d0046faba61f12ced52508d/setup.py'"'"'; __file__='"'"'/tmp/pip-install-gcz7x0j0/openupgradelib_9d8187731d0046faba61f12ced52508d/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-zshxn1wq
         cwd: /tmp/pip-install-gcz7x0j0/openupgradelib_9d8187731d0046faba61f12ced52508d/
    Complete output (7 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-gcz7x0j0/openupgradelib_9d8187731d0046faba61f12ced52508d/setup.py", line 5, in <module>
        import openupgradelib
      File "/tmp/pip-install-gcz7x0j0/openupgradelib_9d8187731d0046faba61f12ced52508d/openupgradelib/__init__.py", line 14, in <module>
        from importlib_metadata import version, PackageNotFoundError
    ModuleNotFoundError: No module named 'importlib_metadata'

Seems related to OCA/openupgradelib#243

@simahawk
Copy link
Contributor

yeah, I got the same issue and reported here #1111
CC @sbidoul

@sbidoul
Copy link
Member

sbidoul commented Sep 22, 2021

Please restart test jobs

@ivantodorovich ivantodorovich changed the title [14.0][ADD] shopinvader_mass_mailing [14.0][ADD] shopinvader_mass_mailing 📨 Sep 22, 2021
@sbidoul
Copy link
Member

sbidoul commented Sep 24, 2021

BTW, this is also a set of REST services that would benefit of being independent of shopinvader (like helpdesk, event, etc).
I think the only abstraction we need is a mechanism to determine the authenticated res.partner.
Then these can go into OCA to benefit and attract broader community.

@simahawk
Copy link
Contributor

I agree, but we could add this to the roadmap for v15.

@sbidoul
Copy link
Member

sbidoul commented Sep 24, 2021

Ah, yes, v15 🤣

@sebastienbeau sebastienbeau added this to the 14.0 milestone Oct 5, 2021
@sebastienbeau
Copy link
Contributor

@PierrickBrun is working on helpdesk case. When he will have a working version he can help on this

@simahawk
Copy link
Contributor

TODO: review sudo changes

ivantodorovich and others added 4 commits October 20, 2022 08:25
When a public endpoint is used, the real use will be 'Public User'
and not the shopinvader tech user.
When a public endpoint is used, the real use will be 'Public User'
and not the shopinvader tech user.
When a public endpoint is used, the real use will be 'Public User'
and not the shopinvader tech user.
@ivantodorovich
Copy link
Contributor Author

rebased to solve conflicts

Copy link
Contributor

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

@sebastienbeau
Copy link
Contributor

/ocabot merge patch

@shopinvader-git-bot
Copy link

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1108-by-sebastienbeau-bump-patch, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Jun 14, 2023
Signed-off-by sebastienbeau
Copy link

github-actions bot commented Mar 3, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale label Mar 3, 2024
@github-actions github-actions bot closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants