Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] [IMP] locomotive easy config #428

Merged

Conversation

lmignon
Copy link
Collaborator

@lmignon lmignon commented Sep 25, 2019

Add new button to easily configure locomotive from informations managed by odoo (api key, odoo url, index names, ....)

…motive from informations managed by odoo (api key, odoo url, index names, ....)
@lmignon lmignon added this to the 12.0 milestone Sep 25, 2019
@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #428 into 12.0 will increase coverage by 0.14%.
The diff coverage is 97.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             12.0     #428      +/-   ##
==========================================
+ Coverage   89.79%   89.94%   +0.14%     
==========================================
  Files         101      104       +3     
  Lines        2774     2834      +60     
==========================================
+ Hits         2491     2549      +58     
- Misses        283      285       +2
Impacted Files Coverage Δ
shopinvader_locomotive/component/adapter.py 88.13% <ø> (-0.39%) ⬇️
shopinvader_locomotive/component/mapper.py 100% <100%> (ø) ⬆️
...search/component/shopinvader_site_export_mapper.py 100% <100%> (ø)
...motive/component/shopinvader_site_export_mapper.py 100% <100%> (ø)
shopinvader_locomotive/component/exporter.py 100% <100%> (ø) ⬆️
...opinvader_locomotive/models/shopinvader_backend.py 89.28% <100%> (+0.82%) ⬆️
shopinvader_demo_app/hooks.py 75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 821d036...8fa53ef. Read the comment docs.

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Great!

Copy link

@Cedric-Pigeon Cedric-Pigeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks.
Code review ok.

Only export products into the 'Meuble' category
When using assortment, specify a category binding level to get the category automatically binded
@lmignon
Copy link
Collaborator Author

lmignon commented Sep 26, 2019

/ocabot merge patch

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-428-by-lmignon-bump-patch, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Sep 26, 2019
Signed-off-by lmignon
@lmignon lmignon mentioned this pull request Sep 26, 2019
77 tasks
@shopinvader-git-bot shopinvader-git-bot merged commit 8fa53ef into shopinvader:12.0 Sep 26, 2019
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 27fc7fa. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon deleted the 12.0-locomotive-easy-config branch September 26, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants