Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][IMP] shopinvader: Add validator for contact types #561

Conversation

rousseldenis
Copy link
Contributor

No description provided.

@rousseldenis rousseldenis added this to the 10.0 milestone Jan 22, 2020
@codecov-io
Copy link

Codecov Report

Merging #561 into 10.0 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             10.0     #561      +/-   ##
==========================================
+ Coverage   89.61%   89.61%   +<.01%     
==========================================
  Files         142      142              
  Lines        3735     3737       +2     
==========================================
+ Hits         3347     3349       +2     
  Misses        388      388
Impacted Files Coverage Δ
shopinvader/services/address.py 93.65% <100%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ddd44c...3991499. Read the comment docs.

Copy link
Contributor

@PierrickBrun PierrickBrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rousseldenis
Copy link
Contributor Author

@shopinvader/shopinvader-maintainers

Copy link
Contributor

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Cedric-Pigeon
Copy link

/ocabot merge patch

@shopinvader-git-bot
Copy link

This PR looks fantastic, let's merge it!
Prepared branch 10.0-ocabot-merge-pr-561-by-Cedric-Pigeon-bump-patch, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Mar 20, 2020
Signed-off-by Cedric-Pigeon
@shopinvader-git-bot
Copy link

It looks like something changed on 10.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 10.0-ocabot-merge-pr-561-by-Cedric-Pigeon-bump-patch, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit b887ae5 into shopinvader:10.0 Mar 20, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at ae887ee. Thanks a lot for contributing to shopinvader. ❤️

@rousseldenis rousseldenis deleted the 10.0-imp-shopinvader_address_type-dro branch March 23, 2020 12:32
@lmignon lmignon mentioned this pull request Sep 1, 2020
77 tasks
This was referenced Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants