Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Scene Export #42

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Feature: Scene Export #42

merged 1 commit into from
Oct 29, 2024

Conversation

ffrank913
Copy link
Contributor

1. Why is this change necessary?

2. What does this change do, exactly?

3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

Copy link
Contributor

@dfrancos-hub dfrancos-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, looks good. One thing, non blocker, just in case you want to adjust, there are some file with an empty line after each code line, the lint doesnt fail though, but it would be nice to have it formatted. Thanks

@ffrank913 ffrank913 merged commit 97c298d into trunk Oct 29, 2024
5 checks passed
@ffrank913 ffrank913 deleted the feature/export-scene branch October 29, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants