Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanation for sitemap configuration #1481

Merged
merged 9 commits into from
Sep 20, 2024
Merged

Conversation

M-arcus
Copy link
Contributor

@M-arcus M-arcus commented Sep 16, 2024

No description provided.

Copy link
Collaborator

@Isengo1989 Isengo1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @M-arcus - please take a look at my suggestions.

@M-arcus
Copy link
Contributor Author

M-arcus commented Sep 19, 2024

@Isengo1989
I have adjusted the code according to your suggestions.
Will you squash before merging, or should I squash and force push?

@Isengo1989
Copy link
Collaborator

@Isengo1989 I have adjusted the code according to your suggestions. Will you squash before merging, or should I squash and force push?

Thx 👍 I will squash the commits before merging :)

@Isengo1989 Isengo1989 merged commit d96afee into shopware:main Sep 20, 2024
5 of 6 checks passed
@M-arcus M-arcus deleted the patch-2 branch September 20, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants