Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Pagination for Wishlist #893

Merged

Conversation

khanSoliheen
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Apr 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Jul 14, 2024 6:38pm

Copy link

codspeed-hq bot commented Apr 26, 2024

CodSpeed Performance Report

Merging #893 will not alter performance

Comparing khanSoliheen:paginationForWishlistOrderHistoryPage (0c683e7) with main (fd3c3a8)

Summary

✅ 9 untouched benchmarks

@BrocksiNet BrocksiNet changed the title addedPaginationForWishlistChangesFewVariableNames feat: added Pagination for Wishlist Apr 30, 2024
Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, looks really good 🙌🏼

👉🏼 Could you please adjust the tests because they are failing

@BrocksiNet
Copy link
Collaborator

hey, looks really good 🙌🏼

👉🏼 Could you please adjust the tests because they are failing

@kstala maybe you can help here? Would be nice to get this merged.

@BrocksiNet
Copy link
Collaborator

BrocksiNet commented May 16, 2024

@mkucmus, @kstala, and @khanSoliheen, I fixed the Test for the useWishlist composable.

Now, we have 100% coverage for the useWishlist composable. 🎉

Can be tested here: https://frontends-demo-h3h90r2m2-shopware-frontends.vercel.app/

Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Few suggestions for the API of composables + ts-ignore to be removed from tests :)

packages/composables/src/useCustomerOrders.ts Outdated Show resolved Hide resolved
packages/composables/src/useCustomerOrders.ts Outdated Show resolved Hide resolved
packages/composables/src/useSyncWishlist.ts Outdated Show resolved Hide resolved
packages/composables/src/useSyncWishlist.ts Show resolved Hide resolved
packages/composables/src/useWishlist.test.ts Outdated Show resolved Hide resolved
packages/composables/src/useWishlist.test.ts Outdated Show resolved Hide resolved
packages/composables/src/useSyncWishlist.ts Outdated Show resolved Hide resolved
packages/composables/src/useWishlist.ts Outdated Show resolved Hide resolved
packages/composables/src/useWishlist.ts Outdated Show resolved Hide resolved
packages/composables/src/useWishlist.ts Outdated Show resolved Hide resolved
templates/vue-demo-store/app.vue Outdated Show resolved Hide resolved
packages/composables/src/useCustomerOrders.ts Outdated Show resolved Hide resolved
@BrocksiNet
Copy link
Collaborator

BrocksiNet commented Jul 10, 2024

FYI: I removed the wishlist call from onMounted because it is not needed information for SSR. I now make sure that the wishlist call is only executed once per page (on the client side), not twice on the wishlist page (like it was before). So overall, this will improve the SSR times a bit.

@patzick patzick merged commit d95751e into shopware:main Jul 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add pagination for wishlist page
6 participants