Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor README.md error - Mentions Symfony 6.2 but 6.3 is now used. #3304

Open
AndreasA opened this issue Sep 7, 2023 · 7 comments
Open

Minor README.md error - Mentions Symfony 6.2 but 6.3 is now used. #3304

AndreasA opened this issue Sep 7, 2023 · 7 comments
Labels
Bug Good first issue Good Issue for your first contribution or experimenting with Shopware Platform(Default)

Comments

@AndreasA
Copy link
Contributor

AndreasA commented Sep 7, 2023

PHP Version

8.2

Shopware Version

6.5.5.1

Expected behaviour

Correct Symfony version is referenced in README.md

Actual behaviour

Wrong Symfoyn version is used in README.md

How to reproduce

check https://github.com/shopware/platform/blob/v6.5.5.1/README.md first sentence. might also be the case for other files.

did not check if the vue.js version is correct.

@AndreasA AndreasA added the Bug label Sep 7, 2023
@mitelg mitelg added the Good first issue Good Issue for your first contribution or experimenting with Shopware label Sep 20, 2023
@tushar-nath
Copy link

@mitelg - Hello! Do I need to update the symfony version from 6.2 to 6.3 in the README.md file? I would like to take up this issue and make a PR on this.

Screenshot 2023-10-26 at 22 23 35

@mitelg
Copy link
Member

mitelg commented Oct 27, 2023

hey @tushar-nath

maybe we can skip the minor version at all? 🤔

With Shopware 6.6 we will upgrade to Symfony 7, so this needs to be changed again. But I guess it would be sufficient to only state the major version of the used frameworks

@tushar-nath
Copy link

@mitelg - understandable! is there any other good first issue to which i can contribute to?

@mitelg
Copy link
Member

mitelg commented Oct 29, 2023

just search for the label 😉
Good first issue Good Issue for your first contribution or experimenting with Shopware

@MarcelSchmaeing
Copy link
Contributor

Hi,

thx for your issue we will put it into our new evaluation process and have a look at it again.

@shopwareBot
Copy link

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-37919.

[created from NEXT-37919, comment 488811]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Good first issue Good Issue for your first contribution or experimenting with Shopware Platform(Default)
Projects
None yet
Development

No branches or pull requests

5 participants