-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEXT-10849 - Add console command to change the system default language #1864
Conversation
@J-Rahe as mentined in the boostday repo |
@breaker92, thanks : ) |
Hey @breaker92, would you mind adding an changelog and add to /change the notice about possible data loss to tell the user to make an database backup before? |
ab36a70
to
d01092a
Compare
@J-Rahe done |
Hello, thank you for creating this pull request. Please use this issue to track the state of your pull request. |
d01092a
to
62f9d75
Compare
Hi @breaker92, To merge this PR you have to the following things first:
|
Hi @breaker92 , please complete your PR otherwise I will close it within the next days. |
$tmpId = Uuid::randomBytes(); | ||
|
||
// assign new uuid to old DEFAULT | ||
$stmt->execute([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may destroy the translation chain, as it is not enforced that all translations are defined in the new default language, maybe we can add a check that verifies that all translations also exist in the new language
|
||
$this->swapDefaultLanguageId($newDefaultLanguageId); | ||
|
||
$output->writeln(sprintf('<info>system default language changed to %s</info>', $newLocale->getCode())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just swapping the default language in the DB is probably not enough, as the old stuff may still be cached or saved in some denormalized structures
So we should clear the cache and rebuild all indexes after swapping the default language
add console command to change the system default language
add selection of a default language when installing Shopware using the cli
shopwareBoostDay#202
1. Why is this change necessary?
Currently the only way to change the system default language is by the install GUI.
2. What does this change do, exactly?
add a console command to change the system default language
3. Describe each step to reproduce the issue or behaviour.
try to configure the system default language , via cli.
4. Please link to the relevant issues (if any).
5. Checklist