Add command to change system language #24

JoshuaBehrens · 2020-03-11T19:58:43Z

Now you can run and get an administration using German as system language. Useful for German only shops that don't force the users to enter English data first. Can be applied to any other locale that shopware ships.

bin/console system:install --create-database --basic-setup --locale=de-DE

Lots of it is 📋🍝 from recovery.

mitelg · 2020-03-26T07:02:17Z

hey @JoshuaBehrens
could you please rebase your branch against master?

JoshuaBehrens · 2020-03-26T11:15:02Z

Feels like a simple rebase is not the solution :D

hlohaus · 2020-03-28T14:16:40Z

src/Command/SystemLocaleCommand.php

+
+    private function getLocaleId(string $iso): string
+    {
+        $stmt = $this->connection->prepare('SELECT locale.id FROM locale WHERE LOWER(locale.code) = LOWER(?)');


you can use like. it's faster.

A like is case insensitive? ... When I just read this. I could've input the argument lowered first 😅 If I use like I have to escape the right-hand-side.

And if we change something here we have to change it in shopware/recovery as well.

The usage of function on the left side is slow, because it can't use the index.

Yes, having a function on the left is slow. Good thing it is not used very frequent. But does like really help here?

it is case insenstive only if the column uses a _ci collation which I think is the case with Shopware columns.
In that case = actually already does the trick. If necessary one can do something like code = 'de-de' COLLATE utf8mb4_unicode_ci to ensure case insensitive column comparison is used. But as mentioned I think Shopware creates columns case insensitive, so it should not be necessary.

CLAassistant · 2020-06-08T11:49:50Z

All committers have signed the CLA.

keulinho · 2020-07-15T14:28:47Z

src/Command/SystemLocaleCommand.php

+        $output->section('Shop locale');
+
+        $locale = $input->getArgument('locale');
+        $this->setDefaultLanguage($locale);


you definetly have to clear the cache after you changed the system language,
the whole entity cache is stale at this point leading to numerous ugly bugs 😆

Been there, done that 🤣

How do suggest to clear the cache? I thought I've done that here. I must admit I am a bit out of the topic by now :D

You've done that when the command get's called as part of the system install command, not if it is run by itself.

You can inject the \Shopware\Core\Framework\Adapter\Cache\CacheClearer into the service and use the clear() method.

Hey @JoshuaBehrens, could you take care of the comment from @keulinho? 🙂

keulinho · 2020-07-15T14:37:33Z

Additionally this can never fully work after the fact:
E.g. we want to switch the default language from englisch to spanish.
After we ran this command every translation in english that is already in the system will actually be in spanish and vice versa, as the translated values are not migrated between the languages.

We should clearly state that shortcomming in the description of the command and maybe even prefix that command with dev: or danger: so it doesn't get executed lightly in a prod env.

It totally makes sense to add the locale option to the system:install command, adding a command in general that allows changing the system default language at any time needs some more consideration.

JoshuaBehrens · 2020-07-15T15:38:34Z

Hey @keulinho I am on it shopware/shopware#860 with the guys from wexo for the command that can be run anytime you want. That is capable of changing every translation at runtime. I run 5 or 6 installations with this pull request and German as default language. At the time of this pull request the boost days were far away. I just need this command to easily integrate it into the setup command.

Relates to shopware#2

JoshuaBehrens · 2020-08-03T01:02:43Z

@keulinho I did some changes to prevent unintended execution. With this lock the cache will get cleared by the followed command in any case so that is not a problem either anymore. My locking might be just a bit... exotic :)

shyim · 2020-08-26T17:13:46Z

Language creation is missing when it's not existing by default
Fix: https://github.com/FriendsOfShopware/production/commit/ff7ea09967c08d8cec336c84bce0077b9714c2d9

AndreasA · 2020-10-21T11:44:42Z

What about currency etc.? Also why not use the ShopService from Recovery for this? might require it to be moved elsewhere?

AndreasA · 2020-10-21T13:37:22Z

Without adjusting the runCommands method like this, it fails for me on the second cache clear, as that one requires the command argument - probably a Symfony bug but this is an easy workaround:

  /**
     * @param array<string, array<string, string>> $commands
     *
     * @return int
     */
    private function runCommands(array $commands, OutputInterface $output): int
    {
        foreach ($commands as $parameters) {
            $output->writeln('');

            $command = $this->getApplication()->find($parameters['command']);
            if (!$command->getDefinition()->hasArgument('command')) {
                unset($parameters['command']);
            }
            $returnCode = $command->run(new ArrayInput($parameters, $command->getDefinition()), $output);
            if ($returnCode !== 0) {
                return $returnCode;
            }
        }

        return 0;
    }

JoshuaBehrens · 2020-10-21T14:00:40Z

@AndreasA this is a problem of this repository. There is already a pull request solving this. I like your approach to exit early when a command fails.

AndreasA · 2020-10-21T14:04:04Z

OK. Thanks for the informatin.

One other thing. In the shopService the swap language command does not disable foreign key checks which is important as otherwise, e.g. the mail template contents will not be switched.

It is done like this:

    private function swapDefaultLanguageId(string $newLanguageId): void
    {
        $stmt = $this->connection->prepare(
            'UPDATE language
             SET id = :newId
             WHERE id = :oldId'
        );

        // assign new uuid to old DEFAULT
        $stmt->execute(
            [
                'newId' => Uuid::randomBytes(),
                'oldId' => Uuid::fromHexToBytes(Defaults::LANGUAGE_SYSTEM),
            ]
        );

        // change id to DEFAULT
        $stmt->execute(
            [
                'newId' => Uuid::fromHexToBytes(Defaults::LANGUAGE_SYSTEM),
                'oldId' => $newLanguageId,
            ]
        );
    }

AndreasA · 2020-10-21T14:06:57Z

src/Command/SystemLocaleCommand.php

+
+    private function swapDefaultLanguageId(string $newLanguageId): void
+    {
+        $this->connection->exec('SET FOREIGN_KEY_CHECKS = 0');


as mentioned in comments, in recovery's ShopService they are not disabled which is a better solution as CASCADE UPDATE takes care of all necessary changes and this way, the content of mail templates etc. is correctly assigned.

Even better would be to re-assign everything correctly afterwards but...

AndreasA · 2020-10-21T14:12:53Z

One more question: In case the system default language is part of a language pack. How would one ensure the language pack is loaded prior to executing the system default change command? Although I guess it does not matter if it is installed afterwards?
Or I would need to install it by modifying the command to activate prior to switching languages? Hmm.. OK for now e.g. the English templates would be used then. would be nice to determine base language for templates - not specific to this command and also to install language packs prior to setting system default which should also setup the mail templates accordingly.

J-Rahe · 2020-12-01T10:19:56Z

This PR was closed due to inactivity. If this change is still important to you, feel free to create a new pull request.
For more information about our contribution guidelines, see https://docs.shopware.com/en/shopware-platform-dev-en/contribution/contribution-guideline

philipreinken · 2021-03-30T09:37:54Z

Hi @JoshuaBehrens , as Niklas said, we'd like to integrate this change, do you think you'll find the time to complete this?

JoshuaBehrens · 2021-03-30T10:16:07Z

Hi @philipgatzka Not before Saturday. Should this make it into the 6.4?

philipreinken · 2021-03-30T11:15:10Z

Glad to hear that, merging this before 6.4 is not a requirement and too short of a timeframe either way I think. I didn't intend to build up pressure here, just wanted to know whether/how we can proceed 🙂 As far as I can tell there's one suggestion still open, just let us know if you need any information or assistance with this or any other roadblocks.

dfsoeten · 2021-06-21T10:44:33Z

I see this pull request is labeled as "scheduled", when can I expect this PR to merged and make it into a future Shopware update? I'm also in need of this feature! 😎

philipreinken · 2021-06-21T12:33:17Z

Hi @dfsoeten , as mentioned above, this PR is still incomplete (I forgot to set the label correctly the last time, sorry for that 🙈). We intend to include the change as soon as it's finished.

dfsoeten · 2021-06-21T12:52:20Z

Ah, that's a mistake on my part then. Haven't read the entire conversation carefully enough. Thank you for clarifying
@philipgatzka !

unugiyen · 2021-07-05T18:01:22Z

SO adding the last suggestion from @keulinho, and PR will be completed? @JoshuaBehrens @shyim

AFAIK:

Change this



if (!empty($input->getOption('locale'))) {
            $this->getApplication()->find('system:locale-destructive')->activateCommand();
            $commands[] = [
                'command' => 'system:locale-destructive',
                'locale' => $input->getOption('locale'),
            ];

            $commands[] = [
                'command' => 'cache:clear',
            ];
        }

To:

if (!empty($input->getOption('locale'))) {
            $this->getApplication()->find('system:locale-destructive')->activateCommand();
            $commands[] = [
                'command' => 'system:locale-destructive',
                'locale' => $input->getOption('locale'),
            ];
        }

ANd than use the cache clearer, since the cache clearer is is clearing in the SystemLocaleCommand?

        $this->setDefaultLanguage($locale);
        $this->cacheClearer->clear();

JoshuaBehrens · 2021-07-06T06:39:28Z

@unugiyen I'll have a look at that :) thank you very much

lukewenkers · 2021-09-06T13:48:38Z

Hi @JoshuaBehrens,
are you still working on this issue or are you currently not working on it?

JoshuaBehrens · 2021-09-06T14:38:22Z

I had a look at @unugiyen changes and they were good but I didn't integrate them yet. Shall I? :)

lukewenkers · 2021-09-07T13:57:35Z

Hi @JoshuaBehrens,
that would be great. 💙

inventory69 · 2021-09-14T06:14:26Z

Please i need this commit in the original shopware production template git <3 @JoshuaBehrens

keulinho · 2021-09-15T06:33:40Z

We will provide an option to do this "shortly" ™️ in the shopware platform,
i'm not sure if switching the default language and currencies afterwards will be supported directly, but we will definetly add support to change the default language and currency during the installation process, which is the most pressing concern i guess.

AndreasA · 2021-11-03T21:13:36Z

@keulinho I think it is now, so I guess this PR could be closed?

After all with 6.4.6.0, there is a command to change it:

https://github.com/shopware/platform/blob/v6.4.6.0/src/Core/Maintenance/System/Command/SystemConfigureShopCommand.php

and it can also be set at the beginning:
https://github.com/shopware/platform/blob/v6.4.6.0/src/Core/Maintenance/System/Command/SystemInstallCommand.php#L41

keulinho · 2021-11-04T06:53:10Z

@AndreasA Yep v6.4.6.0 already includes a command to change the language afterward, and you can set it during CLI set up, so i'm closing this PR.

If you have any issues or anything is missing in those commands, please open another issue or another PR.

JoshuaBehrens · 2021-11-04T08:20:51Z

WE HAVE A COMMAND NOW :O 💙 💙 💙 💙 💙 💙 💙 💙

JoshuaBehrens · 2021-11-04T08:34:28Z

I had a look at it and yes, I will amend it :) nothing troublesome so far. We will see how well it does in our next projects. Thank you so much @keulinho for this command!

JoshuaBehrens · 2022-07-06T14:35:28Z

For all that are running into this. The command is not perfect yet! Change your default language ASAP after installation

JoshuaBehrens mentioned this pull request Mar 11, 2020

Use disabled cache to look up data to link to sales channel shopware/shopware#640

Closed

5 tasks

JoshuaBehrens force-pushed the feature/command-to-set-system-locale branch from 6f5694d to 46a4d61 Compare March 11, 2020 23:10

shopwareBot assigned pweyck Mar 12, 2020

JoshuaBehrens force-pushed the feature/command-to-set-system-locale branch from 46a4d61 to 21c8093 Compare March 26, 2020 11:13

JoshuaBehrens changed the base branch from 6.1 to master March 26, 2020 11:13

JoshuaBehrens force-pushed the feature/command-to-set-system-locale branch from 21c8093 to d502e0f Compare March 26, 2020 11:53

hlohaus suggested changes Apr 16, 2020

View reviewed changes

wexotht mentioned this pull request May 10, 2020

NEXT-8602 - Change Default Language & Currency shopware/shopware#860

Closed

keulinho reviewed Jul 15, 2020

View reviewed changes

Add command to change system language

35c24c3

Relates to shopware#2

JoshuaBehrens force-pushed the feature/command-to-set-system-locale branch from d502e0f to 35c24c3 Compare August 3, 2020 01:01

JoshuaBehrens mentioned this pull request Sep 11, 2020

NEXT-10849 - Allow the selection of a default language when installing Shopware using the cli. shopwareBoostDay/platform#108

Closed

AndreasA reviewed Oct 21, 2020

View reviewed changes

bneumann97 added the Incomplete label Nov 16, 2020

bneumann97 assigned bneumann97 and unassigned pweyck Nov 16, 2020

J-Rahe closed this Dec 1, 2020

ndzoesch reopened this Feb 9, 2021

philipreinken added Scheduled and removed Declined labels Mar 22, 2021

philipreinken added Incomplete and removed Scheduled labels Jun 21, 2021

marcelbrode assigned lukewenkers and unassigned bneumann97 Aug 19, 2021

katzefudder mentioned this pull request Sep 29, 2021

Add an option to set the default language via CLI shopware/shopware#2009

Closed

keulinho closed this Nov 4, 2021

keulinho added Declined and removed Incomplete labels Nov 4, 2021

JoshuaBehrens deleted the feature/command-to-set-system-locale branch November 4, 2021 08:34

Add command to change system language #24

Add command to change system language #24

Conversation

JoshuaBehrens commented Mar 11, 2020

mitelg commented Mar 26, 2020

JoshuaBehrens commented Mar 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CLAassistant commented Jun 8, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

keulinho commented Jul 15, 2020 • edited Loading

JoshuaBehrens commented Jul 15, 2020

JoshuaBehrens commented Aug 3, 2020

shyim commented Aug 26, 2020

AndreasA commented Oct 21, 2020

AndreasA commented Oct 21, 2020

JoshuaBehrens commented Oct 21, 2020

AndreasA commented Oct 21, 2020 • edited Loading

Choose a reason for hiding this comment

AndreasA commented Oct 21, 2020 • edited Loading

J-Rahe commented Dec 1, 2020

philipreinken commented Mar 30, 2021 • edited Loading

JoshuaBehrens commented Mar 30, 2021

philipreinken commented Mar 30, 2021

dfsoeten commented Jun 21, 2021 • edited Loading

philipreinken commented Jun 21, 2021 • edited Loading

dfsoeten commented Jun 21, 2021 • edited Loading

unugiyen commented Jul 5, 2021 • edited Loading

JoshuaBehrens commented Jul 6, 2021

lukewenkers commented Sep 6, 2021

JoshuaBehrens commented Sep 6, 2021

lukewenkers commented Sep 7, 2021

inventory69 commented Sep 14, 2021 • edited Loading

keulinho commented Sep 15, 2021

AndreasA commented Nov 3, 2021 • edited Loading

keulinho commented Nov 4, 2021

JoshuaBehrens commented Nov 4, 2021

JoshuaBehrens commented Nov 4, 2021

JoshuaBehrens commented Jul 6, 2022

CLAassistant commented Jun 8, 2020 •

edited

Loading

keulinho commented Jul 15, 2020 •

edited

Loading

AndreasA commented Oct 21, 2020 •

edited

Loading

AndreasA commented Oct 21, 2020 •

edited

Loading

philipreinken commented Mar 30, 2021 •

edited

Loading

dfsoeten commented Jun 21, 2021 •

edited

Loading

philipreinken commented Jun 21, 2021 •

edited

Loading

dfsoeten commented Jun 21, 2021 •

edited

Loading

unugiyen commented Jul 5, 2021 •

edited

Loading

inventory69 commented Sep 14, 2021 •

edited

Loading

AndreasA commented Nov 3, 2021 •

edited

Loading