refactor(shorebird_cli): introduce ArtifactManager as home for common artifact operations #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/shorebird_cli/test/src/commands/patch/patch_aar_command_test.dart # packages/shorebird_cli/test/src/commands/patch/patch_android_command_test.dart # packages/shorebird_cli/test/src/commands/preview_command_test.dart # packages/shorebird_cli/test/src/mocks.dart
bryanoltman
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1308 +/- ##
==========================================
- Coverage 99.04% 99.04% -0.01%
==========================================
Files 180 181 +1
Lines 4813 4800 -13
==========================================
- Hits 4767 4754 -13
Misses 46 46
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
felangel
reviewed
Sep 22, 2023
| PreviewCommand({ | ||
| http.Client? httpClient, | ||
| }) : _httpClient = httpClient ?? | ||
| retryingHttpClient(LoggingClient(httpClient: http.Client())) { |
There was a problem hiding this comment.
might be nice to have a scoped httpClient for this type of thing
There was a problem hiding this comment.
Agreed, filed #1310
felangel
reviewed
Sep 22, 2023
felangel
reviewed
Sep 22, 2023
felangel
reviewed
Sep 22, 2023
| }) async { | ||
| await Isolate.run(() async { | ||
| final inputStream = InputFileStream(zipFile.path); | ||
| final archive = ZipDecoder().decodeBuffer(inputStream); |
There was a problem hiding this comment.
probably also want to be able to mock the zip decoder to speed up test runs but doesn't have to be done in this PR
felangel
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces the
ArtifactManagerto handle common artifact operations, such a downloading, diffing, and unzipping.Type of Change