Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_code_push_protocol): add platformStatuses to Release #872

Merged
merged 7 commits into from
Jul 19, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

Adds a platform status map to the release response object so the changes in https://github.com/shorebirdtech/_shorebird/pull/266 can be communicated to clients.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e66edad) 100.00% compared to head (acfcec9) 100.00%.

❗ Current head acfcec9 differs from pull request most recent head 0da47f5. Consider uploading reports for the commit 0da47f5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #872     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           69       143     +74     
  Lines          801      3513   +2712     
===========================================
+ Hits           801      3513   +2712     
Impacted Files Coverage Δ
...ird_code_push_protocol/lib/src/models/release.dart 100.00% <ø> (ø)
...horebird_cli/lib/src/code_push_client_wrapper.dart 100.00% <100.00%> (ø)
.../lib/src/commands/release/release_aar_command.dart 100.00% <100.00%> (ø)
.../src/commands/release/release_android_command.dart 100.00% <100.00%> (ø)
.../lib/src/commands/release/release_ios_command.dart 100.00% <100.00%> (ø)
...d_code_push_protocol/lib/src/models/release.g.dart 100.00% <100.00%> (ø)

... and 74 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bryanoltman bryanoltman merged commit 74a0e67 into main Jul 19, 2023
@bryanoltman bryanoltman deleted the bo/release-draft branch July 19, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants